Skip to content

Update Generator_InjectedPromptCharmoniaFwdy_TriggerGap_PbPb5TeV.ini#2130

Merged
lucamicheletti93 merged 3 commits intoAliceO2Group:masterfrom
sgaretti:master
Sep 25, 2025
Merged

Update Generator_InjectedPromptCharmoniaFwdy_TriggerGap_PbPb5TeV.ini#2130
lucamicheletti93 merged 3 commits intoAliceO2Group:masterfrom
sgaretti:master

Conversation

@sgaretti
Copy link
Contributor

@sgaretti sgaretti commented Sep 24, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@sgaretti sgaretti requested a review from a team as a code owner September 24, 2025 11:09
sawenzel
sawenzel requested changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@sawenzel sawenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is pretty major rewrite of a common Pythia8 config. Are you sure that these changes are approved by all PWGs? Alternatively, maybe you could maybe create a copy of this in the DQ folder and modify there.

Also, we would appreciate somewhat more descriptive commit messages that, for example, explain the reasons for a change.

@lucamicheletti93
Copy link
Contributor

lucamicheletti93 commented Sep 24, 2025

Daer @sawenzel ! Sorry for the inconvenience! Probably there has been a misunderstanding when opening the PR. We are checking it!
Luca

@sgaretti
Update pythia8_hi.cfg
6245df8 
Revert changes to pythia8_hi.cfg
@sgaretti sgaretti changed the title Update pythia8_hi.cfg Update Generator_InjectedPromptCharmoniaFwdy_TriggerGap_PbPb5TeV.ini Sep 24, 2025
sgaretti
sgaretti commented Sep 24, 2025
View reviewed changes
Copy link
Contributor Author

@sgaretti sgaretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now pythia8_hi.cfg will be used as Pythia8 generator

@sgaretti
Copy link
Contributor Author

sgaretti commented Sep 24, 2025

Dear @sawenzel,

I realized that some of the changes I initially made were not intended for this PR, so I have removed them.
My apologies for the confusion!
Now, everything should be correct, and the only modified file is Generator_InjectedPromptCharmoniaFwdy_TriggerGap_PbPb5TeV.ini.
I also added a comment, which I had forgotten to include earlier.

Please let me know if there are any further issues; I can close this PR and open a new one if necessary.
Sara

@lucamicheletti93 lucamicheletti93 enabled auto-merge (squash) September 24, 2025 12:47
@sgaretti
Copy link
Contributor Author

sgaretti commented Sep 25, 2025

Dear @sawenzel,
Could you please have a look at the PR now?
Thank you in advance,
Sara

@lucamicheletti93 lucamicheletti93 merged commit 248c287 into AliceO2Group:master Sep 25, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawenzel sawenzel sawenzel approved these changes

@lucamicheletti93 lucamicheletti93 lucamicheletti93 approved these changes

@jackal1-66 jackal1-66 Awaiting requested review from jackal1-66

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sgaretti @lucamicheletti93 @sawenzel